AndrewJSchofield commented on code in PR #20466:
URL: https://github.com/apache/kafka/pull/20466#discussion_r2381547248
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -298,7 +299,8 @@ public class GroupCoordinatorConfig {
public static final ConfigDef CONFIG_DEF = new ConfigDef()
// Group coordinator configs
.define(GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIG, LIST,
GROUP_COORDINATOR_REBALANCE_PROTOCOLS_DEFAULT,
- ConfigDef.ValidList.in(false,
Group.GroupType.documentValidValues()), MEDIUM,
GROUP_COORDINATOR_REBALANCE_PROTOCOLS_DOC)
+
ConfigDef.ValidList.in(GROUP_COORDINATOR_REBALANCE_PROTOCOLS_ALLOWED.toArray(new
String[0])),
Review Comment:
That's because share groups are controlled by a feature. This config was
created before the features were implemented to turn on KIP-848 and KIP-932. I
understand the plan is to deprecate and remove it entirely. It's a really bad
idea having a broker-level config that controls this because individual brokers
might be misconfigured and a cluster is in a mixed state. That's why a feature
is so much better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
