apoorvmittal10 commented on code in PR #20819:
URL: https://github.com/apache/kafka/pull/20819#discussion_r2491178548
##########
clients/src/main/java/org/apache/kafka/common/requests/ShareRequestMetadata.java:
##########
Review Comment:
I was expecting a change here rather than removing the usage of
ShareRequestMetadata
##########
clients/src/main/java/org/apache/kafka/common/requests/ShareRequestMetadata.java:
##########
@@ -39,13 +39,6 @@ public boolean isNewSession() {
return epoch == INITIAL_EPOCH;
}
- /**
- * Returns true if this is a full share fetch request.
- */
- public boolean isFull() {
- return (this.epoch == INITIAL_EPOCH) || (this.epoch == FINAL_EPOCH);
- }
-
Review Comment:
Why this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
