adixitconfluent commented on PR #20819: URL: https://github.com/apache/kafka/pull/20819#issuecomment-3491484549
> Though I have 1 question, in SharePartition we use below, do you think we need to fix there anything? I am expecting it's fine to keep using default as Zero_Uuid in SharePartition, wdyt? > > ``` > /** > * empty member id used to indicate when a record is not acquired by any member. > */ > static final String EMPTY_MEMBER_ID = Uuid.ZERO_UUID.toString(); > ``` I did give it a thought. Since we are not permitting `ZEOR_UUID` as a member id within `KafkaApis`, it should be fine. Also at no place in SharePartition, we've used member id as Uuid and it doesn't go to the persister as well. So, I believe it should be fine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
