AndrewJSchofield commented on code in PR #20819:
URL: https://github.com/apache/kafka/pull/20819#discussion_r2494813009
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -4137,6 +4148,11 @@ class KafkaApis(val requestChannel: RequestChannel,
config.shareGroupConfig.isShareGroupEnabled ||
shareVersion().supportsShareGroups
}
+ // Visible for testing.
+ def isMemberIdValid(memberId: String): Boolean = {
+ memberId.nonEmpty && memberId.length <= 36 &&
!memberId.equals(Uuid.ZERO_UUID.toString)
Review Comment:
I would just demand string length >= 1. A client could use `" "`, but it
would be a terrible choice and they'd get a collision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
