mannoopj commented on code in PR #20707:
URL: https://github.com/apache/kafka/pull/20707#discussion_r2505142083
##########
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##########
@@ -384,8 +384,6 @@ public Builder setUncleanLeaderElectionCheckIntervalMs(long
uncleanLeaderElectio
public QuorumController build() throws Exception {
if (raftClient == null) {
throw new IllegalStateException("You must set a raft client.");
- } else if (bootstrapMetadata == null) {
- throw new IllegalStateException("You must specify an initial
metadata.version using the kafka-storage tool.");
Review Comment:
The idea here is that for when we try to read `bootstrap.checkpoint` from
`KafkaRaftServer`, in the scenarios where this file doesn't exist we would send
a null value. Currently BootstrapDirectory.read() defaults to a non null value.
I was thinking we change this to null as a way of determining if the
bootstrap.checkpoint exists for WARN messages. Unless we do want to keep the
behavior of defaulting to non null records?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
