kevin-wu24 commented on code in PR #20707:
URL: https://github.com/apache/kafka/pull/20707#discussion_r2505175176


##########
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##########
@@ -384,8 +384,6 @@ public Builder setUncleanLeaderElectionCheckIntervalMs(long 
uncleanLeaderElectio
         public QuorumController build() throws Exception {
             if (raftClient == null) {
                 throw new IllegalStateException("You must set a raft client.");
-            } else if (bootstrapMetadata == null) {
-                throw new IllegalStateException("You must specify an initial 
metadata.version using the kafka-storage tool.");

Review Comment:
   > Unless we do want to keep the behavior of defaulting to non null records?
   
   I think we should keep this behavior unless there is a good reason to change 
it. This behavior address the case where the `bootstrap.checkpoint` is 
accidentally deleted before bringing up a cluster.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to