apoorvmittal10 commented on code in PR #20852:
URL: https://github.com/apache/kafka/pull/20852#discussion_r2527607378
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorServiceTest.java:
##########
@@ -4409,89 +4335,6 @@ public void
testDescribeShareGroupAllOffsetsReadSummaryPartitionError() throws I
assertEquals(responseData, future.get());
}
- @Test
- public void testDescribeShareGroupAllOffsetsLatestOffsetError() throws
InterruptedException, ExecutionException {
Review Comment:
You should have either of tests to make sure the handling in
GroupCoordinatorService is done right if there happens to be a future compted
exceptionally.
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##########
Review Comment:
It would be good to have a check here that error can never be non-null, if
it happens then log and throw an exception. It will make sure that no response
will be hanging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
