apoorvmittal10 commented on code in PR #20852:
URL: https://github.com/apache/kafka/pull/20852#discussion_r2533648356
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##########
@@ -1897,6 +1897,11 @@ private void computeShareGroupLagAndBuildResponse(
CompletableFuture.allOf(partitionLatestOffsets.values().toArray(new
CompletableFuture<?>[0]))
.whenComplete((result, error) -> {
+ if (error != null) {
+ log.error("Failed to retrieve partition end offsets while
calculating share partitions lag for share group - {}", groupId, error);
+ responseFuture.completeExceptionally(error);
+ return;
+ }
// The error variable will not be null when one or more of the
partitionLatestOffsets futures get completed exceptionally.
Review Comment:
I suggested to write the comment so we know the parent API should not
ideally complete exceptionally, this information will be lost in future hence
suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
