sjhajharia opened a new pull request, #21708:
URL: https://github.com/apache/kafka/pull/21708
### Summary
Removes the internal configuration group.share.enable that was previously
used to enable share groups (KIP-932) in integration and system tests. Share
groups are now exclusively controlled by the `share.version` feature flag,
which is the proper enablement mechanism for production use.
### Motivation
The `group.share.enable` config was an internal, test-only configuration
that provided a secondary way to enable share groups alongside the proper
share.version feature flag. This dual-enablement mechanism was confusing,
error-prone, not production-ready and temporary.
With share groups now stable and properly gated by the `share.version`
feature flag, this internal config is no longer needed.
### Changes
#### Core Configuration
- `ShareGroupConfig.java`: Removed `SHARE_GROUP_ENABLE_CONFIG`, field, and
getter method
- `KafkaApis.scala`: Simplified `isShareGroupProtocolEnabled(`) to only
check `shareVersion().supportsShareGroups`
- `SharePartitionManager.java`: Removed `isEnabledFromConfig` parameter from
`onShareVersionToggle()`
- `BrokerMetadataPublisher.scala`: Updated to pass only `ShareVersion` to
partition manager
- `ShareCoordinatorService.java`: Removed supplier pattern for config,
simplified `isShareGroupsEnabled()` to only check `ShareVersion` feature
- `BrokerServer.scala`: Removed config supplier from ShareCoordinatorService
builder
#### Tests Updated
- `ShareGroupConfigTest.java`: Removed config assertions and helper parameter
- `GroupConfigTest.java`: Removed config constant
- `ShareConsumerTest.java:` Removed `group.share.enable` cluster property
- `SharePartitionManagerTest.java`: Updated method calls and removed
obsolete test
- `ShareCoordinatorServiceTest.java`: Updated to mock `MetadataImage` with
proper ShareVersion feature flag
- `BrokerMetadataPublisherTest.scala`: Updated method signature verification
- Python system tests: Removed config constant and usage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
