chia7712 commented on code in PR #21708:
URL: https://github.com/apache/kafka/pull/21708#discussion_r2921194903
##########
tests/kafkatest/services/kafka/kafka.py:
##########
@@ -781,9 +781,6 @@ def prop_file(self, node):
for prop in self.per_node_server_prop_overrides.get(self.idx(node),
[]):
override_configs[prop[0]] = prop[1]
- if self.use_share_groups is not None and self.use_share_groups is True:
Review Comment:
I assume this is a flag that allows us to disable the share group initially?
If not, why is the purpose of this option? Also, it seems we don't have any e2e
tests running the dev version without share group. If we don't intend to
support this flag, we should probably remove it from `kafka.py` to avoid
confusing developers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
