chia7712 commented on code in PR #21708:
URL: https://github.com/apache/kafka/pull/21708#discussion_r2922355692
##########
tests/kafkatest/services/kafka/kafka.py:
##########
@@ -781,9 +781,6 @@ def prop_file(self, node):
for prop in self.per_node_server_prop_overrides.get(self.idx(node),
[]):
override_configs[prop[0]] = prop[1]
- if self.use_share_groups is not None and self.use_share_groups is True:
Review Comment:
> now only controls share coordinator topic configuration (replication
factor and min ISR
Out of curiosity, is this control necessary? What happens if we always set
those configurations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
