dajac commented on code in PR #21730:
URL: https://github.com/apache/kafka/pull/21730#discussion_r2925373006


##########
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##########
@@ -430,6 +431,7 @@ class DynamicBrokerConfig(private val kafkaConfig: 
KafkaConfig) extends Logging
     newProps ++= staticBrokerConfigs
     overrideProps(newProps, dynamicDefaultConfigs)
     overrideProps(newProps, dynamicBrokerConfigs)
+    GroupCoordinatorConfig.clampDynamicConfigs(newProps.asJava)

Review Comment:
   I see... Thanks for clarifying. I don't really like having this here though. 
Have you considered alternative approaches?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to