squah-confluent commented on code in PR #21730:
URL: https://github.com/apache/kafka/pull/21730#discussion_r2926018315
##########
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##########
@@ -430,6 +431,7 @@ class DynamicBrokerConfig(private val kafkaConfig:
KafkaConfig) extends Logging
newProps ++= staticBrokerConfigs
overrideProps(newProps, dynamicDefaultConfigs)
overrideProps(newProps, dynamicBrokerConfigs)
+ GroupCoordinatorConfig.clampDynamicConfigs(newProps.asJava)
Review Comment:
Defining `KafkaConfig.clampDynamicConfigs` makes sense.
And then we can either call it here or in the `KafkaConfig` constructor. If
it's the latter we have to thread through an extra bool through
`processReconfiguration`. Both threading the bool vs not threading are about
the same for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
