dajac commented on code in PR #21730:
URL: https://github.com/apache/kafka/pull/21730#discussion_r2925766313
##########
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##########
@@ -430,6 +431,7 @@ class DynamicBrokerConfig(private val kafkaConfig:
KafkaConfig) extends Logging
newProps ++= staticBrokerConfigs
overrideProps(newProps, dynamicDefaultConfigs)
overrideProps(newProps, dynamicBrokerConfigs)
+ GroupCoordinatorConfig.clampDynamicConfigs(newProps.asJava)
Review Comment:
At minimum, I think that we should have a `clampDynamicConfigs` methods in
`KafkaConfig` so we avoid the coupling with `GroupCoordinatorConfig` here. It
would also give a hit to folks adding configs to `KafkaConfig`.
I was also considering whether we should just introduce a new argument to
the `KafkaConfig`, say `clampDynamicConfigs`. I am not sure whether it is
better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
