adikou commented on PR #22270: URL: https://github.com/apache/kafka/pull/22270#issuecomment-4563648773
> My inclination is to add a rebalance cause to the `RebalanceConsumer` interface, in preference to `RebalanceContext` since I find it a bit odd having what users will consider to be consumer methods on a new thing called a context. I agree that `context.consumer().commit()` is verbose. That works for me. Then the only change required would be the interface refactor and set method to point to the superclass instead. Since we're rebuilding the `RebalanceConsumer` from scratch with new methods we can add custom ones like cause in there too. I'll amend the KIP and start a new vote soon. Thank you both for a lively discussion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
