adikou commented on code in PR #22270:
URL: https://github.com/apache/kafka/pull/22270#discussion_r3312957006
##########
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRebalanceListener.java:
##########
@@ -154,18 +171,45 @@ public interface ConsumerRebalanceListener {
* necessary to catch these exceptions and re-attempt to wakeup or
interrupt the consumer thread.
*
* @param partitions The list of partitions that were assigned to the
consumer and now need to be revoked. This will
- * include the full assignment under the Classic/Eager
protocol, given that it revokes all partitions.
+ * include the full assignment under the Classic/Eager
protocol, given that it revokes all partitions.
* It will only include the subset to revoke under the
Classic/Cooperative and Consumer protocols.
* @throws org.apache.kafka.common.errors.WakeupException If raised from a
nested call to {@link KafkaConsumer}
* @throws org.apache.kafka.common.errors.InterruptException If raised
from a nested call to {@link KafkaConsumer}
*/
- void onPartitionsRevoked(Collection<TopicPartition> partitions);
+ default void onPartitionsRevoked(Collection<TopicPartition> partitions) {}
Review Comment:
Yes, I see. It would preserve compat the same way with existing
implementations all unchanged. Defining a standalone super-interface that's not
really implementable is already present in the codebase I see: like
`Measurable` (or `Serializable` in java).
Although I would have liked the reverse in terms of naming since the
`ConsumerRebalanceListener` is the root of this with ConsumerAware being the
extension point.
Since we're naming the new interface `RebalanceConsumer` in the param, can
we name the new super-interface `RebalanceListener` so they're similarly named
- the `Consumer` is implied since they're already in the `o.a.k.c.consumer`
package. We can then mark `ConsumerRebalanceListener` as deprecated and remove
in 5.0 to avoid confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
