adikou commented on PR #22270: URL: https://github.com/apache/kafka/pull/22270#issuecomment-4560860730
> `context.consumer().commit()` is a bit verbose to me. Maybe we could make `RebalanceConsumer` return a context/metadata instead? Or we could rename `RebalanceConsumer` to `RebalanceSession`, which makes it semantically reasonable to flatten the composition I'm down for flattening the hierarchy. However, `RebalanceSession` makes it sound like it could be more long-lived than the intermediate callback method alone. How about `RebalanceState` or `RebalanceScope`? For instance, `rebalanceState.commit()` when you're ready to commit in a revoked method. `rebalanceState.getRebalanceCause()` for logging/emitting custom metrics down the line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
