nileshkumar3 commented on code in PR #22634:
URL: https://github.com/apache/kafka/pull/22634#discussion_r3449600665
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -2119,6 +2124,13 @@ private CoordinatorResult<StreamsGroupHeartbeatResult,
CoordinatorRecord> stream
.maybeUpdateProcessId(Optional.ofNullable(processId))
.maybeUpdateClientTags(Optional.ofNullable(clientTags).map(x ->
x.stream().collect(Collectors.toMap(KeyValue::key, KeyValue::value))));
+ if (taskOffsets != null) {
Review Comment:
if a client sends an empty TaskOffsets / TaskEndOffsets list (non-null [])
rather than leaving the field null, should that clear the stored offsets, or
should we treat empty the same as null (“unchanged”)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
