gabriellefu commented on code in PR #22634:
URL: https://github.com/apache/kafka/pull/22634#discussion_r3453232260
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -2119,6 +2124,13 @@ private CoordinatorResult<StreamsGroupHeartbeatResult,
CoordinatorRecord> stream
.maybeUpdateProcessId(Optional.ofNullable(processId))
.maybeUpdateClientTags(Optional.ofNullable(clientTags).map(x ->
x.stream().collect(Collectors.toMap(KeyValue::key, KeyValue::value))));
+ if (taskOffsets != null) {
Review Comment:
I think the client only need to send their offset if there's any change, so
if the offset is 100, then it's also 100, the client won't send the offset but
we should still keep the 100 in the coordinator instead of clear it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
