nileshkumar3 commented on code in PR #22634:
URL: https://github.com/apache/kafka/pull/22634#discussion_r3454345524
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -2119,6 +2124,13 @@ private CoordinatorResult<StreamsGroupHeartbeatResult,
CoordinatorRecord> stream
.maybeUpdateProcessId(Optional.ofNullable(processId))
.maybeUpdateClientTags(Optional.ofNullable(clientTags).map(x ->
x.stream().collect(Collectors.toMap(KeyValue::key, KeyValue::value))));
+ if (taskOffsets != null) {
Review Comment:
Thanks — agreed on null = unchanged. the current code treats a non-null
empty list differently from null ([] would overwrite stored offsets with an
empty map). Should we treat empty the same as null, e.g. only update when
taskOffsets != null && !taskOffsets.isEmpty()? Or is sending [] explicitly
unsupported and clients will always use null for unchanged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
