mjsax commented on code in PR #22156:
URL: https://github.com/apache/kafka/pull/22156#discussion_r3479159636
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java:
##########
@@ -248,38 +253,40 @@ private void emitNonJoinedOuterRecords(final
KeyValueStore<TimestampedKeyAndJoin
continue;
}
- final LeftOrRightValue<VLeft, VRight> leftOrRightValue =
nextKeyValue.value;
- forwardNonJoinedOuterRecords(record,
timestampedKeyAndJoinSide, leftOrRightValue);
+ forwardNonJoinedOuterRecords(record,
timestampedKeyAndJoinSide, nextKeyValue.value);
Review Comment:
Yes, please add the local variable. With (nested) generics it becomes very
hard to reason about types and read the code; that's why we did do the same in
the existing code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
