mjsax commented on code in PR #22156: URL: https://github.com/apache/kafka/pull/22156#discussion_r3479170549
########## streams/src/main/java/org/apache/kafka/streams/state/internals/OuterJoinStoreWrapper.java: ########## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.streams.state.internals; + +import org.apache.kafka.common.header.Headers; +import org.apache.kafka.streams.DslStoreFormat; +import org.apache.kafka.streams.KeyValue; +import org.apache.kafka.streams.kstream.internals.AbstractConfigurableStoreFactory; +import org.apache.kafka.streams.processor.api.ProcessorContext; +import org.apache.kafka.streams.processor.internals.StoreFactory; +import org.apache.kafka.streams.state.KeyValueIterator; +import org.apache.kafka.streams.state.KeyValueStore; +import org.apache.kafka.streams.state.ValueTimestampHeaders; + +/** + * Wraps the outer-join store used by {@code KStreamKStreamJoin} so the processor only deals + * with a single value shape: {@code ValueTimestampHeaders<LeftOrRightValue<VLeft, VRight>>}. + * <p> + * The underlying store is one of: + * <ul> + * <li>plain: {@code KeyValueStore<TimestampedKeyAndJoinSide<K>, LeftOrRightValue<VLeft, VRight>>}</li> + * <li>headers-aware: {@code KeyValueStore<TimestampedKeyAndJoinSide<K>, ValueTimestampHeaders<LeftOrRightValue<VLeft, VRight>>>}</li> + * </ul> + * Both variants are wrapped by the same {@link MeteredKeyValueStore} class — they only differ Review Comment: Cannot remember what I mean... It's three weeks back. Your link (`here`) doesn't work -- guess it broke after you pushed an update to the PR. Resolving for now. If I remember later what I meant, I can re-open, or add a better comment somewhere else. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
