aliehsaeedii commented on code in PR #22156:
URL: https://github.com/apache/kafka/pull/22156#discussion_r3595845692
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/OuterStreamJoinStoreFactory.java:
##########
@@ -96,7 +94,9 @@ public StoreBuilder<?> builder() {
final TimestampedKeyAndJoinSideSerde<K> timestampedKeyAndJoinSideSerde
= new TimestampedKeyAndJoinSideSerde<>(streamJoined.keySerde());
final LeftOrRightValueSerde<V1, V2> leftOrRightValueSerde = new
LeftOrRightValueSerde<>(streamJoined.valueSerde(),
streamJoined.otherValueSerde());
- // Once the headers-aware version of ListValueStore is implemented
(planned for AK 4.4), replace the PLAIN constant with the dslStoreFormat()
method.
+ // We always use the PLAIN underlying bytes-store supplier: the
per-element headers
+ // (when in HEADERS mode) are embedded inside each list element's
value bytes, so
+ // the bytes-store layer itself needs no special header support.
Review Comment:
oh, big headache! then I have to re-design everything:(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
