frankvicky commented on code in PR #22752:
URL: https://github.com/apache/kafka/pull/22752#discussion_r3527555077
##########
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##########
@@ -724,9 +728,26 @@ protected Map<String, Object>
postProcessParsedConfig(final Map<String, Object>
maybeOverrideClientId(refinedConfigs);
maybeOverrideEnableAutoCommit(refinedConfigs);
checkUnsupportedConfigsPostProcess();
+ warnIfConnectionsMaxIdleMsLowerThanMaxPollIntervalMs();
return refinedConfigs;
}
+ private void warnIfConnectionsMaxIdleMsLowerThanMaxPollIntervalMs() {
+ String groupProtocol = getString(GROUP_PROTOCOL_CONFIG);
+ if (!GroupProtocol.CLASSIC.name().equalsIgnoreCase(groupProtocol)) {
+ return;
+ }
+ long connectionsMaxIdleMs = getLong(CONNECTIONS_MAX_IDLE_MS_CONFIG);
+ int maxPollIntervalMs = getInt(MAX_POLL_INTERVAL_MS_CONFIG);
+ if (connectionsMaxIdleMs >= 0 && connectionsMaxIdleMs <
maxPollIntervalMs) {
Review Comment:
Good question. `rebalance.timeout.ms` isn't registered in `ConsumerConfig` —
it's a Connect-only config.
I'm not sure if we should deal it in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
