frankvicky commented on code in PR #22752:
URL: https://github.com/apache/kafka/pull/22752#discussion_r3580979375
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedConfig.java:
##########
@@ -598,9 +598,22 @@ public String groupId() {
@Override
protected Map<String, Object> postProcessParsedConfig(final Map<String,
Object> parsedValues) {
CommonClientConfigs.warnDisablingExponentialBackoff(this);
+ warnIfConnectionsMaxIdleMsLowerThanRebalanceTimeoutMs();
return super.postProcessParsedConfig(parsedValues);
}
+ private void warnIfConnectionsMaxIdleMsLowerThanRebalanceTimeoutMs() {
Review Comment:
Thanks for the review! IIUC the worker group here uses connect.protocol
(Eager/Compatible/Sessioned) via WorkerCoordinator extends AbstractCoordinator,
which runs on the classic group-coordinator path. The
group.protocol=classic|consumer switch from KIP-848 applies to consumer groups,
not Connect worker groups — so the coordinator-connection-reaping concern
applies here regardless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
