chia7712 commented on code in PR #22752:
URL: https://github.com/apache/kafka/pull/22752#discussion_r3580919601
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedConfig.java:
##########
@@ -598,9 +598,22 @@ public String groupId() {
@Override
protected Map<String, Object> postProcessParsedConfig(final Map<String,
Object> parsedValues) {
CommonClientConfigs.warnDisablingExponentialBackoff(this);
+ warnIfConnectionsMaxIdleMsLowerThanRebalanceTimeoutMs();
return super.postProcessParsedConfig(parsedValues);
}
+ private void warnIfConnectionsMaxIdleMsLowerThanRebalanceTimeoutMs() {
Review Comment:
IIRC, we can enable the CONSUMER protocol on the connector, right? If so,
the warning should only be printed when using the CLASSIC protocol
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
