UladzislauBlok commented on code in PR #21971:
URL: https://github.com/apache/kafka/pull/21971#discussion_r3573199077
##########
streams/src/test/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStoreWithHeadersTest.java:
##########
@@ -697,4 +699,21 @@ public void
shouldUseHeadersFromValueToDeserializeKeyInPrefixScan() {
// The critical verification: key deserializer must have been called
with HEADERS (not empty headers)
verify(keyDeserializer).deserialize(any(), eq(HEADERS),
eq(KEY.getBytes()));
}
+
+ @Test
+ public void shouldUseHeadersFromContextForPrefixSerialization() {
Review Comment:
Overall I prefer high level / public api level tests with small number of
mock, however in this case effectively there is no changes to other stores
I'm not sure this kind of test (in this particular case) will give us much
value, as it will check that underlying stores are doing nothing
This test _may be_ could be useful from future regression checking point of
view, but rn I cannot image how underlying stores could even brake current
logic. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
