UladzislauBlok commented on code in PR #21971:
URL: https://github.com/apache/kafka/pull/21971#discussion_r3573300657
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStoreWithHeaders.java:
##########
@@ -548,7 +551,8 @@ public <PS extends Serializer<P>, P> KeyValueIterator<K,
ValueTimestampHeaders<V
) {
Objects.requireNonNull(prefix, "prefix cannot be null");
Objects.requireNonNull(prefixKeySerializer, "prefixKeySerializer
cannot be null");
- return prefixScanInternal(wrapped(), prefix, prefixKeySerializer);
+ final byte[] keyBytes = prefixKeySerializer.serialize(null,
internalContext.headers(), prefix);
+ return prefixScanInternal(wrapped(), keyBytes, BYTE_ARRAY_SERIALIZER);
Review Comment:
Wow. This actually good catch! When I first implemented this fix,
`IsolationLevel` KIP wasn't here yet, and after rebase I didn't realized it
also has to be fixed :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
