mjsax commented on code in PR #21971:
URL: https://github.com/apache/kafka/pull/21971#discussion_r3598508720
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/CachingKeyValueStore.java:
##########
@@ -438,6 +438,7 @@ private <PS extends Serializer<P>, P>
KeyValueIterator<Bytes, byte[]> prefixScan
final ReadOnlyKeyValueStore<Bytes, byte[]> underlying) {
validateStoreOpen();
final KeyValueIterator<Bytes, byte[]> storeIterator =
underlying.prefixScan(prefix, prefixKeySerializer);
+ // headers aren't needed because the prefix already arrives serialized
Review Comment:
> f you're asking from perspective of metered vs underlying: this is because
underlying doesn't have an access to context, meaning we can't really get
headers
I see. Thanks for clarifying.
> I can fix basic store as well, but we still need to keep the fix on
`MeteredTimestampedKeyValueStoreWithHeaders`
Yes, makes sense. Let add the same fix to `MeteredKeyValueStore` -- we did
similar improvement already in the past as part of the headers work for
non-header store (ie, the work we did to alway pass headers into all serdes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
