lianetm commented on code in PR #21080:
URL: https://github.com/apache/kafka/pull/21080#discussion_r3595257209
##########
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java:
##########
@@ -391,11 +391,14 @@ public NetworkClient(MetadataUpdater metadataUpdater,
this.metadataRecoveryStrategy = metadataRecoveryStrategy;
this.metadataClusterCheckEnable = metadataClusterCheckEnable;
this.bootstrapConfiguration = bootstrapConfiguration;
- // Bootstrap timer is lazily initialized on first poll to ensure
timeout starts when polling begins
Review Comment:
don't we need to keep like behaviour? (timer starting on the first poll).
If we start the timer any sooner and let's say dns fails, it won't be
retried until the first poll, but we would still be consuming time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
