dino2895 commented on code in PR #22854:
URL: https://github.com/apache/kafka/pull/22854#discussion_r3617544421
##########
storage/src/test/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerTest.java:
##########
@@ -216,7 +216,7 @@ public class RemoteLogManagerTest {
private UnifiedLog mockLog = mock(UnifiedLog.class);
private final MockScheduler scheduler = new MockScheduler(time);
- private final Properties brokerConfig =
kafka.utils.TestUtils.createDummyBrokerConfig();
+ private final Properties remoteLogManagerProps = new Properties();
Review Comment:
It is populated in setUp() through the `props` alias, and some tests
copy it to add test-specific properties. Would you prefer that I make
the common configuration explicit and immutable, and have individual
tests create copies when they need overrides?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
