chia7712 commented on code in PR #22854:
URL: https://github.com/apache/kafka/pull/22854#discussion_r3618329319
##########
storage/src/test/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerTest.java:
##########
@@ -216,7 +216,7 @@ public class RemoteLogManagerTest {
private UnifiedLog mockLog = mock(UnifiedLog.class);
private final MockScheduler scheduler = new MockScheduler(time);
- private final Properties brokerConfig =
kafka.utils.TestUtils.createDummyBrokerConfig();
+ private final Properties remoteLogManagerProps = new Properties();
Review Comment:
My point is that `remoteLogManagerProps` is a kind of base configuration
that other tests can use to make specific settings. However, this logic
duplicates `appendRLMConfig`. See the following patch for an example:
[tmp.patch](https://github.com/user-attachments/files/30207315/tmp.patch)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
