squah-confluent commented on code in PR #22788:
URL: https://github.com/apache/kafka/pull/22788#discussion_r3630129406
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/TargetAssignmentBuilder.java:
##########
@@ -116,17 +117,19 @@ public TargetAssignmentBuilder(
this.assignmentConfigs = Objects.requireNonNull(assignmentConfigs);
}
- static AssignmentMemberSpec createAssignmentMemberSpec(
+ static MemberMetadataAndAssignmentImpl createMemberMetadataAndAssignment(
StreamsGroupMember member,
TasksTuple targetAssignment,
MemberTaskOffsets taskOffsets
) {
- return new AssignmentMemberSpec(
+ return new MemberMetadataAndAssignmentImpl(
member.instanceId(),
member.rackId(),
targetAssignment.activeTasks(),
targetAssignment.standbyTasks(),
Review Comment:
It's intentional and I don't recall the reasoning for it. It does lead to
some weirdness, such as
[KAFKA-19405](https://issues.apache.org/jira/browse/KAFKA-19405). I think we
should discuss with @dajac.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
