squah-confluent commented on code in PR #22788: URL: https://github.com/apache/kafka/pull/22788#discussion_r3630115083
########## group-coordinator/group-coordinator-api/src/main/java/org/apache/kafka/coordinator/group/api/streams/assignor/GroupAssignment.java: ########## @@ -24,6 +27,8 @@ * * @param members The member assignments keyed by member ID. */ [email protected] [email protected] public record GroupAssignment(Map<String, MemberAssignment> members) { Review Comment: I didn't follow the KIP too closely but I think the reason we went with a class is that it's easier to evolve in the future. When adding a new field, we can add a constructor overload and initialize it with a sensible default, whereas a record will require constructor changes and break any code that tries to use the old constructor signature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
