mjsax commented on code in PR #22788: URL: https://github.com/apache/kafka/pull/22788#discussion_r3632011856
########## group-coordinator/group-coordinator-api/src/main/java/org/apache/kafka/coordinator/group/api/streams/assignor/GroupAssignment.java: ########## @@ -24,6 +27,8 @@ * * @param members The member assignments keyed by member ID. */ [email protected] [email protected] public record GroupAssignment(Map<String, MemberAssignment> members) { Review Comment: > When adding a new field, we can add a constructor overload and initialize it with a sensible default, whereas a record will require constructor changes and break any code that tries to use the old constructor signature. `record` still allows to add an overloaded constructor... it's still true, that overall `record` is less flexible than `class` though, so I also don't have any objections to change _all_ `record` types in public API to `interface` or `class`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
