kaijaytu commented on code in PR #23235:
URL: https://github.com/apache/kafka/pull/23235#discussion_r3840489309
##########
server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java:
##########
@@ -205,10 +207,10 @@ public void
testRegisterBrokerRecordVersion(MetadataVersion metadataVersion) {
}
@Test
- public void assertLatestProductionIsLessThanLatest() {
- assertTrue(LATEST_PRODUCTION.ordinal() <
MetadataVersion.latestTesting().ordinal(),
+ public void assertLatestProductionIsNotAfterLatestTesting() {
Review Comment:
Reworked following the #23244 pattern:
- Added `IBP_4_5_IV0` as the unstable placeholder
- Reverted the `MetadataVersionTest` changes -- the three tests are back to
their original strict assertions
- Updated the default `metadataVersion()` in `ClusterTest` to `IBP_4_5_IV0`
- The `FormatterTest` changes from the previous commit (`assumeFalse` guards
and `SV_2`) are kept, matching the current state of trunk after #23244
Local `./gradlew build` is green. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
