chia7712 commented on code in PR #23235:
URL: https://github.com/apache/kafka/pull/23235#discussion_r3841905464
##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -124,21 +124,24 @@ public enum MetadataVersion {
// BrokerRegistrationChangeRecord and RegisterBrokerRecord are updated
IBP_4_3_IV0(30, "4.3", "IV0", true),
- //
- // NOTE: MetadataVersions after this point are unstable and may be changed.
- // If users attempt to use an unstable MetadataVersion, they will get an
error unless
- // they have set the configuration unstable.feature.versions.enable=true.
- // Please move this comment when updating the LATEST_PRODUCTION constant.
- //
-
// IBP_4_4_IV0 enables dead-letter queue support for share groups
(KIP-1191).
IBP_4_4_IV0(31, "4.4", "IV0", false),
// Add support for CIDR-based ACL host patterns (KIP-1276).
IBP_4_4_IV1(32, "4.4", "IV1", true),
// Add support for controller unregistration (KIP-1312).
- IBP_4_4_IV2(33, "4.4", "IV2", true);
+ IBP_4_4_IV2(33, "4.4", "IV2", true),
+
+ //
+ // NOTE: MetadataVersions after this point are unstable and may be changed.
+ // If users attempt to use an unstable MetadataVersion, they will get an
error unless
+ // they have set the configuration unstable.feature.versions.enable=true.
+ // Please move this comment when updating the LATEST_PRODUCTION constant.
+ //
+
+ // New version for the Kafka 4.5.0 release.
Review Comment:
I'm a bit nitpicky, so would you mind removing this comment? The above
comment is clear enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
