kaijaytu commented on code in PR #23235:
URL: https://github.com/apache/kafka/pull/23235#discussion_r3848945489
##########
metadata/src/test/java/org/apache/kafka/metadata/storage/FormatterTest.java:
##########
@@ -300,6 +301,7 @@ public void testFormatWithOlderReleaseVersion() throws
Exception {
@Test
public void
testFormatWithUnstableReleaseVersionFailsWithoutEnableUnstable() throws
Exception {
try (TestEnv testEnv = new TestEnv(1)) {
+ assumeFalse(MetadataVersion.latestTesting().isProduction());
Review Comment:
Roger that.
Removed the two assumeFalse guards + import per your suggestion. With
IBP_4_5_IV0 as the enum tail, latestTesting().isProduction() is already false,
so they were no-ops.
Force-pushed b07a61c372. FormatterTest 32/32 pass, spotless/checkstyle clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
