vvcephei commented on a change in pull request #8764:
URL: https://github.com/apache/kafka/pull/8764#discussion_r433487031
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionWrapperSerde.java
##########
@@ -63,9 +63,9 @@ public SubscriptionWrapperSerde(final Supplier<String>
primaryKeySerializationPs
}
@Override
- public void setIfUnset(final Serializer<K> defaultSerializer) {
+ public void setIfUnset(final Serializer<K> defaultKeySerializer, final
Serializer<Void> defaultValueSerializer) {
if (primaryKeySerializer == null) {
- primaryKeySerializer =
Objects.requireNonNull(defaultSerializer, "defaultSerializer cannot be null");
+ primaryKeySerializer =
Objects.requireNonNull(defaultKeySerializer);
Review comment:
@guozhangwang , this (and L128) is the "actual fix". Previously, the
actual default serde we would pass in was the value serde (in
SinkNode/SourceNode), but this one particular serde needs the key serde. If you
look at the other serdes that changed in this diff, you'll note that they all
actually do need the value serde. Only this one is different.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
