vvcephei commented on a change in pull request #8764:
URL: https://github.com/apache/kafka/pull/8764#discussion_r433487600
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionWrapperSerde.java
##########
@@ -63,9 +63,9 @@ public SubscriptionWrapperSerde(final Supplier<String>
primaryKeySerializationPs
}
@Override
- public void setIfUnset(final Serializer<K> defaultSerializer) {
+ public void setIfUnset(final Serializer<K> defaultKeySerializer, final
Serializer<Void> defaultValueSerializer) {
if (primaryKeySerializer == null) {
- primaryKeySerializer =
Objects.requireNonNull(defaultSerializer, "defaultSerializer cannot be null");
+ primaryKeySerializer =
Objects.requireNonNull(defaultKeySerializer);
Review comment:
Oh, hah. Looks like you beat me to it, @bellemare :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
