scanterog commented on a change in pull request #9313: URL: https://github.com/apache/kafka/pull/9313#discussion_r502351930
########## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java ########## @@ -52,10 +52,10 @@ public void testClusterConfigProperties() { "replication.factor", "4")); Map<String, String> connectorProps = mirrorConfig.connectorBaseConfig(new SourceAndTarget("a", "b"), MirrorSourceConnector.class); - assertEquals("source.cluster.bootstrap.servers is set", - "servers-one", connectorProps.get("source.cluster.bootstrap.servers")); - assertEquals("target.cluster.bootstrap.servers is set", - "servers-two", connectorProps.get("target.cluster.bootstrap.servers")); + assertEquals("source.bootstrap.servers is set", Review comment: That will require more changes. This does not break for the mirrorMaker driver main config. I guess it does for on Connect though ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org