scanterog commented on a change in pull request #9313:
URL: https://github.com/apache/kafka/pull/9313#discussion_r503489280
##########
File path:
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java
##########
@@ -52,10 +52,10 @@ public void testClusterConfigProperties() {
"replication.factor", "4"));
Map<String, String> connectorProps =
mirrorConfig.connectorBaseConfig(new SourceAndTarget("a", "b"),
MirrorSourceConnector.class);
- assertEquals("source.cluster.bootstrap.servers is set",
- "servers-one",
connectorProps.get("source.cluster.bootstrap.servers"));
- assertEquals("target.cluster.bootstrap.servers is set",
- "servers-two",
connectorProps.get("target.cluster.bootstrap.servers"));
+ assertEquals("source.bootstrap.servers is set",
Review comment:
I think I have achieved what we want. Explicitly setting "source."
prefix for props starting with consumer|producer|admin and setting
"source.cluster." otherwise. All tests passed. The code runs fine on my infra.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
