ableegoldman commented on a change in pull request #9446:
URL: https://github.com/apache/kafka/pull/9446#discussion_r508185204
##########
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignorTest.java
##########
@@ -1899,14 +1973,18 @@ public void
shouldRequestEndOffsetsForPreexistingChangelogs() {
@Test
public void shouldRequestCommittedOffsetsForPreexistingSourceChangelogs() {
final Set<TopicPartition> changelogs = mkSet(
- new TopicPartition(APPLICATION_ID + "-store-changelog", 0),
- new TopicPartition(APPLICATION_ID + "-store-changelog", 1),
- new TopicPartition(APPLICATION_ID + "-store-changelog", 2)
+ new TopicPartition("topic1", 0),
+ new TopicPartition("topic1", 1),
+ new TopicPartition("topic1", 2)
);
final StreamsBuilder streamsBuilder = new StreamsBuilder();
Review comment:
I happened to notice that this test was not actually using this
`streamsBuilder`, so I tried to fix that and it broke. After some debugging I
realized this test was broken in so many different ways that it's a miracle it
was ever passing at all. Luckily all the bugs were in the test and not in the
actual code 🙏
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
