vvcephei commented on a change in pull request #9446:
URL: https://github.com/apache/kafka/pull/9446#discussion_r508866077
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsRebalanceListener.java
##########
@@ -52,8 +53,16 @@ public void onPartitionsAssigned(final
Collection<TopicPartition> partitions) {
// NB: all task management is already handled by:
//
org.apache.kafka.streams.processor.internals.StreamsPartitionAssignor.onAssignment
if (assignmentErrorCode.get() ==
AssignorError.INCOMPLETE_SOURCE_TOPIC_METADATA.code()) {
- log.error("Received error code {}", assignmentErrorCode.get());
+ log.error("Received error code {}",
AssignorError.INCOMPLETE_SOURCE_TOPIC_METADATA);
throw new MissingSourceTopicException("One or more source topics
were missing during rebalance");
+ } else if (assignmentErrorCode.get() ==
AssignorError.VERSION_PROBING.code()) {
+ log.info("Received error code {}", AssignorError.VERSION_PROBING);
Review comment:
Maybe we shouldn't say "error" when it's not an error. I'm just
imagining the mailing list questions that will start pouring in...
```suggestion
log.info("Received version probing code {}",
AssignorError.VERSION_PROBING);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
