ableegoldman commented on a change in pull request #9487:
URL: https://github.com/apache/kafka/pull/9487#discussion_r523311219



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/SubscriptionInfo.java
##########
@@ -115,6 +119,10 @@ private SubscriptionInfo(final SubscriptionInfoData 
subscriptionInfoData) {
         this.data = subscriptionInfoData;
     }
 
+    public int errorCode() {
+        return data.errorCode();

Review comment:
       What happens if we try to read the error code of an earlier subscription 
version? I genuinely don't know what the generated code does, but we should 
make sure it doesn't throw an NPE or something. Could you add a unit test for 
this case?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to