ableegoldman commented on a change in pull request #9487:
URL: https://github.com/apache/kafka/pull/9487#discussion_r523319677
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/KStreamRepartitionIntegrationTest.java
##########
@@ -144,6 +143,7 @@ public void whenShuttingDown() throws IOException {
}
@Test
+ @Deprecated //a single thread should no longer die
Review comment:
I think any test that's trying to verify some unrelated behavior and
just using the "one thread dies at a time" paradigm as a tool to do so should
not be deleted. I'm sure in most if not all cases, there's some way to modify
the test to verify that specific behavior either using the new handler or
multiple apps or rewriting it altogether.
But, there are a lot of tests that do this and a lot of them are pretty
tricky, so I wouldn't want to stall this PR on waiting for all of these tests
to be updated/adapted. I think we should file tickets for all of these tests
and just try to pick up one or two of them every so often. Maybe that's being
overly optimistic about our inclination to pick up small tasks even over a long
period, but it's better than losing track of them altogether. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
