ijuma commented on a change in pull request #9728:
URL: https://github.com/apache/kafka/pull/9728#discussion_r540467496
##########
File path: core/src/main/scala/kafka/log/LogManager.scala
##########
@@ -435,6 +436,20 @@ class LogManager(logDirs: Seq[File],
cleaner.startup()
}
+ /**
+ * wait all jobs to complete
+ * @param jobs jobs
+ * @return true if all pass. Otherwise, false
+ */
+ private[log] def allPass(jobs: Seq[Future[_]]): Boolean = {
Review comment:
The log message talks explicitly about LogManager shutdown. Seems like
you'd want it to say something about log manager shutdown. I would even set the
type parameter to the type we expect from the shutdown method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
