ijuma commented on a change in pull request #9728:
URL: https://github.com/apache/kafka/pull/9728#discussion_r543396355
##########
File path: core/src/main/scala/kafka/log/LogManager.scala
##########
@@ -435,6 +436,20 @@ class LogManager(logDirs: Seq[File],
cleaner.startup()
}
+ /**
+ * wait all jobs to complete
+ * @param jobs jobs
+ * @return true if all pass. Otherwise, false
+ */
+ private[log] def waitForAllToComplete(jobs: Seq[Future[_]]): Boolean = {
Review comment:
I would add a callback here for the failures and do the logging in the
callback. That way you can keep the name generic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
