chia7712 commented on a change in pull request #9728:
URL: https://github.com/apache/kafka/pull/9728#discussion_r540483941
##########
File path: core/src/test/scala/unit/kafka/log/LogManagerTest.scala
##########
@@ -680,4 +680,15 @@ class LogManagerTest {
time.sleep(logConfig.fileDeleteDelayMs + 1)
verifyMetrics(1)
}
+
+ @Test
Review comment:
@kowshik Thanks for you explanation! It is indeed hard to give full test
on the shutdown path.
> This test may not still catch the bug introduced in #9680.
you are right. I'm going to enrich the unit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
