cmccabe commented on a change in pull request #9883:
URL: https://github.com/apache/kafka/pull/9883#discussion_r557070495
##########
File path: core/src/main/scala/kafka/raft/RaftManager.scala
##########
@@ -95,15 +95,15 @@ trait RaftManager[T] {
}
class KafkaRaftManager[T](
- nodeId: Int,
- baseLogDir: String,
recordSerde: RecordSerde[T],
topicPartition: TopicPartition,
config: KafkaConfig,
time: Time,
metrics: Metrics
) extends RaftManager[T] with Logging {
+ private val nodeId = config.brokerId
+ private val baseLogDir = config.logDirs.head
Review comment:
this isn't quite correct since we could also have a specifically
configured metadata.log.dir
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
